Closed MichaelMarner closed 3 years ago
@MichaelMarner thanks for your efforts in chasing down the dependencies and migrating them... you're a legend! I'll update and let you know if I come across any issues... thanks again 👍
Actually I just noticed in your PR on redux_dev_tools the author said he was going to make some additional changes then publish, maybe it's worth waiting for that before trying out this version? I imagine not much will change but it sounds like it shouldn't be long to wait... what do you think?
Hey @nickmeinhold - Yep, once the the deps have been published on pub.dev I'll update this PR to point to them and fix up anything that needs it.
Just wanted to get this up for feedback so people can try it out. We're a fair way away from being able to move CareApp to sound null safety, but migrating the packages we control is the obvious first step.
Totals | |
---|---|
Change from base Build 141: | 0.5% |
Covered Lines: | 79 |
Relevant Lines: | 85 |
This PR migrates Redux Remote Devtools to null safety. I'd appreciate feedback from anybody using this, in particular any issues. I've migrated the two example projects and things seem to work without really any modification, but real projects are always different.
Right now this is not publishable, as we will need updates to https://github.com/pauldemarco/socketcluster_client/pull/14 and https://github.com/brianegan/redux_dev_tools/pull/6 to be published to pub.dev.
In the interim I've pointed this project to use my forks of both those packages.
As you can see from the changes, migrating this library to null safety actually required fairly minimal changes. Most of the work was testing due to the fairly extensive issues Mockito has with null safety.
Counter example migrated with minimal changes. The Github example needed a bit more work, mostly because the code is just so old.
Anyway please point your null safe app at this and tell me what you think
Cheers