MichaelMarner / dart-redux-remote-devtools

Remote Devtools for Dart & Flutter
https://pub.dartlang.org/packages/redux_remote_devtools
MIT License
52 stars 10 forks source link

Handles the START response #9

Closed MichaelMarner closed 5 years ago

MichaelMarner commented 5 years ago

Closes #8

Replaces the previous started boolean with an enum of possible states.

Only set the status to started after receiving the START response. Previously we assumed we were started after we sent the initial START message.

This makes room for a stream so apps can listen to the status changes, but this does not include the stream.

Add unit tests for verifying status set correctly.

cc @zbarbuto

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 56


Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/remote_devtools_middleware.dart 11 12 91.67%
<!-- Total: 11 12 91.67% -->
Files with Coverage Reduction New Missed Lines %
lib/src/remote_devtools_middleware.dart 1 91.49%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 50: 1.9%
Covered Lines: 65
Relevant Lines: 69

💛 - Coveralls