search

MichaelPachec0 / nodejs-project-night

Project night for May 27 2022
MIT License
5 stars 12 forks source link

remove unnecessary directory #24

Closed SarahMelki closed 2 years ago

SarahMelki commented 2 years ago

Fixes #23 - I deleted a subdirectory with an additional CSS file since we have one in the public folder along with the front-end javascript and HTML.

MichaelPachec0 commented 2 years ago

Hey Sarah it looks like you were working on #23 and the change look good, want to get people used to reviewing commits so for the moment ive changed this pull request to be a draft that way people wont accidentally commit code without people looking at the commit/code.

SarahMelki commented 2 years ago

Sounds good, Michael! Just learned there's a draft PR :)

MichaelPachec0 commented 2 years ago

As ive mentioned to others, make sure that at the very least the description has a reference to the issue that this pull request is fixing. You should be able to edit the description (on the right hand side of the description there are three dots, clicking on that should give you an option to edit) and add a bit of info there. Ideally this should should be in the commit message and the title so when referencing commits everyone can see what commit fixes what. For the purposes of this project we dont have to worry about that.

As the project owner it should be my responsibility to make sure people know to do this. So this is on me. 😓

Once this is done i will in turn convert this from a draft pr to a regular one so that it can be merged.

jericashall commented 2 years ago

Looks good, like Michael said just make sure that you have a description.

JoeDravarol commented 2 years ago

@SarahMelki I think you just have to references #23 in your description then it'll be perfect! It lets others and the repository owner know which issue you were tackling.

SarahMelki commented 2 years ago

@SarahMelki I think you just have to references #23 in your description then it'll be perfect! It lets others and the repository owner know which issue you were tackling.

Got you! 👍