MichaelPachec0 / nodejs-project-night

Project night for May 27 2022
MIT License
5 stars 12 forks source link

Adding HTML, CSS animations, and pokemon images. Fixes #16 #30

Closed CodingWithDan closed 2 years ago

CodingWithDan commented 2 years ago
MichaelPachec0 commented 2 years ago

Ok just fixed the merge issues, ill ask for more people to review the commit and the code.

jericashall commented 2 years ago

This looks great!

SarahMelki commented 2 years ago

Just got the chance to look at the code. Looks very neat, well done!!

SarahMelki commented 2 years ago

The code looks great!

 /* An idea for JavaScript: toggle "hidden" class when clicked. Remove "hidden" class permanently when two cards match*/
 .card .hidden .card-back{
    transform: rotateY(-180deg);
 }

 .card .hidden .card-front{
    transform: rotateX(0deg);
 }

I just have a question for the flipping animation. You mention we can just toggle the '.hidden' class to trigger the flip animation, I've tried testing just that on codepen it doesn't seem to work. It would be great if you could expand on that so the JavaScript developer can know what they should do to trigger the animation.

Joe and Dan, I did read Dan's code again, and I tried to use the 'hidden' class as such:

toggleCards() {
        this.cardsArray.forEach(card => {
            card.classList.remove('hidden');
        });
    }

this method is part of the class that I'm writing to check if the cards match. I have to complete the class though, to see if it will work completely. Look forward to your thoughts!

CodingWithDan commented 2 years ago

Haha I see! I'm just about done with work, so I'll take a look at make the requested changes this evening.

CodingWithDan commented 2 years ago

Just put up a new version. Let me know if this one works @JoeDravarol

JoeDravarol commented 2 years ago

Just put up a new version. Let me know if this one works @JoeDravarol

Great job, looks perfect to me! I'm going to merge this PR so other member can start working on their parts.