search

MichaelPilyavskiy / ReaScripts

Scripts for REAPER written by MichaelPilyavskiy (mpl)
131 stars 46 forks source link

RS5k manager: 'New kit' function is not undoable #30

Closed IOphonics closed 1 year ago

IOphonics commented 2 years ago

It's probably related to the 'pad replace' issue, because it shows the same symptoms. The names revert when you hit undo, but not the samples.

MichaelPilyavskiy commented 2 years ago

Is that fixed for 3.0beta53?

IOphonics commented 2 years ago

Problem unfortunately remains.

MichaelPilyavskiy commented 1 year ago

It seems I cant fix that. The code performs is just

reaper.Undo_BeginBlock2( 0) DATA2:Actions_DB_InitRandSamples() reaper.Undo_EndBlock2( 0, 'RS5k manager / Database / New kit', 0xFFFFFFFF )

and i don`t know internal mechanism of REAPER undo when we at complex scripts area. It suppose to [print stuff - do something - print stuff] but unfortunately it does not doing this.

MichaelPilyavskiy commented 1 year ago

Ah I see undo history is written but when I open actually Undo history it doesn`t show, it seems a REAPER issue https://forum.cockos.com/showthread.php?p=2612868#post2612868

IOphonics commented 1 year ago

Very interesting. We should let them know.