search

MichaelSel / edoJS

A set of functions for manipulating musical pitches within a given EDO
GNU Affero General Public License v3.0
5 stars 0 forks source link

[PAPER] Some minor corrections #10

Closed napulen closed 2 years ago

napulen commented 2 years ago

This issue is related to the following review: openjournals/joss-reviews#3784

https://github.com/MichaelSel/edoJS/blob/feb06495b1ce4ed3a957ce2d4c1e08bb8fd67893/paper.md?plain=1#L32

EDO.js is by far the most comprehensive library that supports non-standard tuning to date

Any references/experiments to support the claim? Otherwise, it feels a bit hyperbolic. I'd tone it down a cent:

"EDO.js is, to the best of our knowledge, the most comprehensive library supporting non-standard tuning."

MichaelSel commented 2 years ago

Corrected the typos and changed the line to: Most critically, EDO.js is, to the best of our knowledge, the most comprehensive library to supports non-standard tuning to date.

MichaelSel commented 2 years ago

Should this issue be closed?

napulen commented 2 years ago

On the last correction, a small typo supports -> support.

napulen commented 2 years ago

Just bringing it up, I don't need to see the correction.

Closing the issue now.