MichaelSinsbeck / platformer

A ninja platformer written in LÖVE
7 stars 0 forks source link

Continue uploading process, even if level is saved first #183

Closed michalove closed 10 years ago

michalove commented 10 years ago

When I haven't saved the game and try to upload it, the editor tells me that I should save it first. But if I then save it then, it does not continue to upload. So I have to hit "upload" once more.

I expected it upload it automatically in this case. That means we need a "queue" in the editor, that saves, what actions are performed, when the current one is done.

Germanunkol commented 10 years ago

Yes, I noticed this too and thought the same. It requires quite a bit of coding/restructuring, but it's probably necessary. I'll add this.

michalove commented 10 years ago

Alternatively, we could replace the "upload" button in the menu by a "save and upload" button. The next thing would be a dialog with the exact same content as the "save" dialog but with a "save and upload" button, instead of "save" only.

About icons: For the upload functionality, we could either have an arrow pointing to a globe (and the reverse for download), or we could use the "share" symbol: https://cdn1.iconfinder.com/data/icons/bloggers-1-to-7-vol-PNG/512/share_this_icon.png

Germanunkol commented 10 years ago

Icons: I like both ideas, but the globe icon has the advantage that we can simply invert the arrow, as you mention. So I think that would be the better choice. The "problem" is that icons in the editor are monochrome while the main menu icons are coloured. This means that we'll have to break style somewhere... Edit: Will re-open as new issue, since the original point here is fixes.

The fix still needs some testing (there might be cases where it now tries to upload even though it shouldn't), but I think it works.

Edit2: Btw, I ended up using a "proper" fix, I believe. It ended up being simpler than I thought...