MichaelSolati / geofirestore-js

Location-based querying and filtering using Firebase Firestore.
https://geofirestore.com
MIT License
505 stars 58 forks source link

Support for Firebase JS SDK 9 #219

Open tu4mo opened 3 years ago

tu4mo commented 3 years ago

Sorry for not using the template, I don't have a bug to report. Only curious if you have plans to support the new Firebase SDK?

MichaelSolati commented 3 years ago

I haven't had time to keep up to date with firebase. I'd say yes though, I'm not even sure if there are compatibility issues, so I'll take some time over the next week to test and update the library to support v9.

Ok, it looks like SDK v9 isn't official yet and is still in beta. So I will add support for it when it launched, but unlikely before. There's some work on testing I'm going to focus on before that, though I'll keep the issue open until v9 lands.

MichaelSolati commented 2 years ago

So i've been super busy and haven't been able to get to this yet... If you're using the compat you can just ignore the typing error, but as for supporting modular I'll hopefully look at it over the holidays.

spotvin42 commented 2 years ago

Hello, any news on supporting the Modular approach?

So i've been super busy and haven't been able to get to this yet... If you're using the compat you can just ignore the typing error, but as for supporting modular I'll hopefully look at it over the holidays.

MichaelSolati commented 2 years ago

Ok, so I've updated the lib to v5 which supports cloud and web compat (as they're basically the same). I'm currently working on the modular solution, but that will take some time and planning... It is coming though.

pdandradeb commented 2 years ago

In my case, the mobile clients only update their locations on firestore but don't query so I removed the client library and replaced the update with:

import { hash } from 'geokit';
await updateDoc(doc(firestore, 'collection', id), {
 coordinates: location,
  g: {
    geopoint: location,
    geohash: hash({
      lat: location.latitude,
      lng: location.longitude,
    }),
  }
});
Spark-Cybel commented 2 years ago

Hello, any update on supporting the Modular approach?

Ok, so I've updated the lib to v5 which supports cloud and web compat (as they're basically the same). I'm currently working on the modular solution, but that will take some time and planning... It is coming though.

hschk commented 1 year ago

Hi, Do you have any updates on supporting modular version of firebase?

kimonneuhoff commented 1 year ago

Can we help you with anything @MichaelSolati ?

pikilon commented 1 year ago

Hello I could help too