MichaelSolati / geofirestore-js

Location-based querying and filtering using Firebase Firestore.
https://geofirestore.com
MIT License
505 stars 58 forks source link

Cannot find namespace 'FirebaseFirestore'. #22

Closed MvRemmerden closed 6 years ago

MvRemmerden commented 6 years ago

After updating to 2.1.0., the following error appears: Cannot find namespace 'FirebaseFirestore'.

I was able to fix it by changing FirebaseFirestore.CollectionReference to typesWeb.CollectionReference in the following lines:

export namespace cloud { export interface CollectionReference extends FirebaseFirestore.CollectionReference { } }

I have created PR to fix this issue. #23

MichaelSolati commented 6 years ago

Oy vey! @MvRemmerden that may not work for the cloud functions. Shoot, I'll get on this right away (thank you for making me aware)

MvRemmerden commented 6 years ago

Ah, makes sense, I was just testing out the firestore queries, not the cloud functions. And no worries, always happy to help :)

MichaelSolati commented 6 years ago

Can you post a screenshot of the error, as well as what version of Typescript you're using?

MvRemmerden commented 6 years ago

screen shot 2018-08-07 at 09 24 03

TypeScript 2.6.2

MichaelSolati commented 6 years ago

Fascinating, I'm not getting this. Mind you I'm on Typescript 3.0.1... Hrmm, ok, I can try and work from this!

MvRemmerden commented 6 years ago

Just updated to Typescript 3.0.1, still same error. Might be due to my project running on Ionic and with AngularFire2.

MichaelSolati commented 6 years ago

Yea, that didn't fix it, I'll have to try more tomorrow in the morning. Ughhh, sorry for the inconvenience!

MvRemmerden commented 6 years ago

No worries, it's not an inconvenience at all, as I don't need the cloud functions and can just continue with my forked version.

MichaelSolati commented 6 years ago

Try npm i MichaelSolati/geofirestore#dev, I've tried it with a few different projects and a few different versions of Typescript. If I get a yes that works I'll be deploying it to NPM today!

MichaelSolati commented 6 years ago

@MvRemmerden I'm gonna take it as we're fine and deploy 2.1.1

MvRemmerden commented 6 years ago

Sorry for the late reaction, yes it works!