Fix/parse time or error60

MichaelXavier / cron

Cron data structure and parser for Haskell

Other

53 stars 33 forks source link

Fix/parse time or error60 #42

Closed sir4ur0n closed 4 years ago

sir4ur0n commented 4 years ago

Here is the PR. I tried as much as possible to stick to the style of the lib (which doesn't seem to use Hindent or Ormolu, but seems to use Stylish Haskell for import formatting). I am also not a library author (I'm more of an application author) so there may be best/bad practices I am not aware of, feel free to pinpoint them!

Add LTS 15 to Travis CI
Cleanup stack.yaml and provide LTS-13 specific Stack file
Isolate business logic from IO for next minute
Add unit and property tests to business code for next minute (which pass on LTS 14 but fail on LTS 15 for the same reason as #41)
Remove the CPP pragma and condition as all used functions are available in time-1.4.0 which is the lower bound in the Cabal dependencies
Clean some minor Hlint warnings

Closes #41

sir4ur0n commented 4 years ago

@MichaelXavier here it is!

sir4ur0n commented 4 years ago

I forgot to mention, maybe this will reassure some: in the meantime we have shipped this PR on our platforms (our stack.yaml targets my fork), and it fixes the issue, everything else seems to work fine.

sir4ur0n commented 4 years ago

@MichaelXavier I think I finally fixed the build :disappointed:

Basically I noticed you had frozen the Hedhehog version - I assume because it wasn't there in LTS 13 - but the referenced version is no longer possible for LTS 15. So I changed the build logic slightly: there is a dedicated Stack file for LTS 13 and another one - more standard - for all other LTSes.

Thus I removed the cache on .stack-work as it sometimes uses the LTS 13 cache for others and vice-versa. Also, caching on .stack-work doesn't have much impact on build/test/bench time.

Let me know if it's ok for you!

sir4ur0n commented 4 years ago

@MichaelXavier sorry to bump, but do you think you could take some time to review this PR please?

Thank you!

MichaelXavier commented 4 years ago

Looks great! Sorry for the delay, this slipped my mind. This is released as 0.7.0. Thanks for taking care of this.

sir4ur0n commented 4 years ago

Thank you very much!

I noticed the documentation is not published on the Hackage page, is there something we can do about it? https://hackage.haskell.org/package/cron-0.7.0

paolino commented 4 years ago

it takes a while to be processed

sir4ur0n commented 4 years ago

Perfect, thank you, it's now available 😄

MichaelXavier commented 4 years ago

I think it gets generated eventually?