MichaelYochpaz / iSubRip

A Python command-line tool for scraping and downloading subtitles from AppleTV and iTunes movie pages.
MIT License
113 stars 15 forks source link

[Issue]: Apple TV IDs shorted than 24 characters are not recognized #46

Closed vevv closed 1 year ago

vevv commented 1 year ago

Confirmations

OS Type

Windows

Python Version

3.10.6

Package Version

2.4.2

Description

Some Apple TV IDs are only 23 characters long. Changing the regex here fixes the issue: https://github.com/MichaelYochpaz/iSubRip/blob/main/isubrip/scrapers/appletv_scraper.py#L20

Example: https://tv.apple.com/ca/movie/umc.cmc.sa30371iduf6frzmmat3mwh

Output Log

Scraping https://tv.apple.com/ca/movie/umc.cmc.sa30371iduf6frzmmat3mwh
Error: No matching scraper was found for URL 'https://tv.apple.com/ca/movie/umc.cmc.sa30371iduf6frzmmat3mwh'

Config

No response

MichaelYochpaz commented 1 year ago

Hey, thanks for the report. Noticed that as well. Seems to be that some of the new releases have shorter IDs. Will be fixed in an update soon.

MichaelYochpaz commented 1 year ago

Fixed in the new release (2.4.3)