search

MichaelYochpaz / iSubRip

A Python command-line tool for scraping and downloading subtitles from AppleTV and iTunes movie pages.
MIT License
113 stars 15 forks source link

[Issue]: Fix a possible error or bug in the subtitle download order. #56

Closed rDamascena closed 9 months ago

rDamascena commented 9 months ago

Confirmations

OS Type

Windows

Python Version

3.11.6

Package Version

2.5.1

Description

The subtitle "English (US) (en-US) [CC]" is being downloaded last. As it seems to me, the subtitles are downloaded in alphabetical order from an IETF language tag. But I don't know if it's exactly an error or bug.

Output Log

$ isubrip "https://tv.apple.com/br/movie/que-horas-eu-te-pego/umc.cmc.jv4x80nydofuh6a5b1nmg5kc"
User config file detected at 'C:\Users\Adriana\.isubrip\config.toml' and will be used.
Scraping 'https://tv.apple.com/br/movie/que-horas-eu-te-pego/umc.cmc.jv4x80nydofuh6a5b1nmg5kc'...
Found movie: No Hard Feelings [2023] (ID: 1690701761)
العربية (ar) subtitles were successfully downloaded.
български (bg) subtitles were successfully downloaded.
中文（简体） (cmn-Hans) subtitles were successfully downloaded.
中文（繁體） (cmn-Hant) subtitles were successfully downloaded.
Čeština (cs) subtitles were successfully downloaded.
dansk (da) subtitles were successfully downloaded.
Deutsch (Deutschland) (de-DE) subtitles were successfully downloaded.
Ελληνικά (el) subtitles were successfully downloaded.
English (UK) (en-GB) subtitles were successfully downloaded.
English (en) [Forced] subtitles were successfully downloaded.
Español (Latinoamérica) (es-419) subtitles were successfully downloaded.
Español (España) (es-ES) subtitles were successfully downloaded.
eesti (et) subtitles were successfully downloaded.
Suomi (fi) subtitles were successfully downloaded.
Français (France) (fr-FR) subtitles were successfully downloaded.
עברית (he) subtitles were successfully downloaded.
magyar (hu) subtitles were successfully downloaded.
Italiano (Italia) (it-IT) subtitles were successfully downloaded.
한국어 (ko) subtitles were successfully downloaded.
lietuvių (lt) subtitles were successfully downloaded.
latviešu (lv) subtitles were successfully downloaded.
Nederlands (nl) subtitles were successfully downloaded.
norsk (no) subtitles were successfully downloaded.
polski (pl) subtitles were successfully downloaded.
Português (Brasil) (pt-BR) subtitles were successfully downloaded.
Português (Brasil) (pt-BR) [Forced] subtitles were successfully downloaded.
português (Portugal) (pt-PT) subtitles were successfully downloaded.
Русский (ru) subtitles were successfully downloaded.
Slovenčina (sk) subtitles were successfully downloaded.
slovenščina (sl) subtitles were successfully downloaded.
Svenska (sv) subtitles were successfully downloaded.
ไทย (th) subtitles were successfully downloaded.
Türkçe (tr) subtitles were successfully downloaded.
українська (uk) subtitles were successfully downloaded.
廣東話 (yue-Hant) subtitles were successfully downloaded.
***English (US) (en-US) [CC] subtitles were successfully downloaded.***
36/36 matching subtitles have been successfully downloaded.

Config

No response

MichaelYochpaz commented 9 months ago

Hey, this is not an error or a bug. The subtitles are downloaded according to the order they appear on the playlist they're downloaded from.

The order has no effective meaning, the final result of the downloaded files is the same, no matter what the downloading order is. Closing as I don't see any benefit in implementing an option to sort the downloading order.