search

MichaelZaidman / hid-ft260

FTDI FT260 Linux kernel driver
GNU General Public License v2.0
20 stars 6 forks source link

Add attribute for wakeup interupt enable/disable + GPIO controle #12

Closed PixmaHestiia closed 9 months ago

PixmaHestiia commented 11 months ago

This PR add a new RW attribute for the wakeup/interupt function "enable_wakeup_int". Also, when changing the uart_mode attribute and the i2c_enable attribute, the gpio_en value is updated accordingly. When the uart_mode is "OFF" then all the GPIO_PIN associated with the uart are available. Same for i2c_enable.

MichaelZaidman commented 10 months ago

@PixmaHestiia, I cannot apply this PR due to the following reasons:

  1. It is not based on the latest state of the main branch.
  2. It implies the UART support merged.
  3. The commits need rework to meet Linux kernel commits' look and feel.

But again, thanks for this work. After merging UART support, I will review and use these changes with your credentials. Till then, let's keep the PR open.

antoine-sac commented 9 months ago

@MichaelZaidman understandable - we do plan to clean up this PR but this is currently in our backlog as we're working hard to deliver our product on time and have a very small team. @PixmaHestiia is keen to do it as soon as he's available!