Fix opencv framework search path

[Pompette]

4

The way it was done was not working the way it's write in the documentation. The opencv framework was linked to the module instead of root project.

To make it work we should have to copy the framework into /node_modules/react-native-perspective-image-cropper/ios, that means that each time we reinstall dependencies into the project, we should have done the copy step.

I have changed the path to the parent project so it's not annoying anymore.

[Michaelvilleneuve]

Hi, thank you very much ! Correct me if I'm wrong, just so I understand correctly, with your PR this lib will now use the parent project open CV module ?

[Pompette]

Hi, you are welcome. Yes, with this PR it's now using the parent project open cv framework. So it match the documentation now.

[Michaelvilleneuve]

Ok nice! Things were becoming confusing indeed 👍

[willelundborg]

How much space does using OpenCV module grow app size for a RN app? Thanks, Wilhelm

On Mon, Oct 15, 2018 at 2:23 PM Michaël Villeneuve notifications@github.com wrote:

Merged #15 https://github.com/Michaelvilleneuve/react-native-perspective-image-cropper/pull/15 into master.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Michaelvilleneuve/react-native-perspective-image-cropper/pull/15#event-1903929924, or mute the thread https://github.com/notifications/unsubscribe-auth/AbwgVP_Zp7WCHLiB4-sYWptYlICdLJBUks5ulH4kgaJpZM4XcKl- .

[Michaelvilleneuve]

@willelundborg Not much, less than a MB. I made this lib to use it in this app : https://itunes.apple.com/fr/app/papiers-always-keep-your-papers-close/id1253490112?l=fr&ls=1&mt=8

As you can see, the app is only 8MB/13MB (depending on the device), including my code/assets, the entire React Native lib.

[willelundborg]

Excellent, thanks!

On Mon, Oct 15, 2018 at 3:07 PM Michaël Villeneuve notifications@github.com wrote:

@willelundborg https://github.com/willelundborg Not much, less than a MB. I made this lib to use it in this app : https://itunes.apple.com/fr/app/papiers-always-keep-your-papers-close/id1253490112?l=fr&ls=1&mt=8

As you can see, the app is only 8MB/13MB (depending on the device), including my code/assets, the entire React Native lib.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Michaelvilleneuve/react-native-perspective-image-cropper/pull/15#issuecomment-429843838, or mute the thread https://github.com/notifications/unsubscribe-auth/AbwgVHYw226quH_yvvM6ufQVVD6j9p6zks5ulIisgaJpZM4XcKl- .