Open armin23615 opened 4 years ago
I faced the same issue and since no one replied i tried to fix it myself and after many hours of trial and error i did managed to fix it and enhanced the usage, use this modified component for testing
react-native-perspective-image-cropper.zip
Make sure to change android/settings.gradle to point to the folder where you have pasted the component for e.g
include ':rreact-native-perspective-image-cropper' project(':react-native-perspective-image-cropper').projectDir = new File(rootProject.projectDir, '../src/components/react-native-document-scanner/android')
and change import statement to
import CustomCrop from "../../components/react-native-perspective-image-cropper"
If your issue is fixed as well, i can make a PR
Thank you so much, this works great! There is just one line in index.js -> import Exif from 'react-native-exif' It's not used anywhere and it prevents building app if 'react-native-exif' package isn't installed.
Thank you so much, this works great! There is just one line in index.js -> import Exif from 'react-native-exif' It's not used anywhere and it prevents building app if 'react-native-exif' package isn't installed.
Oops, my bad, i was just tinkering with exif to see if it helps and forgot to remove it, glad that it worked though :)
@maknom66 IOS still same issue please help.
can any one can send source code ?
source code for only file where u used this component
thankyou so so much @maknom66 .
@maknom66 Did you manage to resolve this issue on iOS? Your version works really well on Android but as @hashimkhatri mentioned it is not cropping correctly on iOS.
@maknom66 Thanks so much for the fix! If you have time please make a PR. I would like to avoid manual inclusion of the resources if possible.
ould like to avoid
@maknom66 In android working fine, Having issue in iOS after capturing image from camera, While picking image from gallery in that scenario it's working fine.
++ @Michaelvilleneuve
please see my PR #64
I faced the same issue and since no one replied i tried to fix it myself and after many hours of trial and error i did managed to fix it and enhanced the usage, use this modified component for testing
react-native-perspective-image-cropper.zip
Make sure to change android/settings.gradle to point to the folder where you have pasted the component for e.g
include ':rreact-native-perspective-image-cropper' project(':react-native-perspective-image-cropper').projectDir = new File(rootProject.projectDir, '../src/components/react-native-document-scanner/android')
and change import statement to
import CustomCrop from "../../components/react-native-perspective-image-cropper"
If your issue is fixed as well, i can make a PR
Thank You you save my day
react-native: 0.60.5 react-native-perspective-image-cropper": "^0.4.4
Original:![Screenshot_20200220-164834_Straight_Line 1](https://user-images.githubusercontent.com/56969846/74953136-8e75b280-5401-11ea-9c4c-146b258ceb42.jpg)
Selected coords:![Screenshot_20200220-165037_Straight_Line 1](https://user-images.githubusercontent.com/56969846/74953174-9d5c6500-5401-11ea-8ab0-cdc76827eb60.jpg)
Result:![Screenshot_20200220-165046_Straight_Line 1](https://user-images.githubusercontent.com/56969846/74953196-a6e5cd00-5401-11ea-8a11-3c827953a21c.jpg)
Any idea how to fix this?