MichalD96 / Perico-heist-goods-counter

MIT License
8 stars 4 forks source link

It was working nice but recently it doesnt give correct results #22

Open antonyblinker opened 3 days ago

antonyblinker commented 3 days ago

Target is pink diamond there's 3 golds and no cocaine. The leader gets more money if they went there as 2 players. But you add one more player and he suppose to get less money because theres no extra take. But this shows either nothing changes or leader gets more money when you add more players even tho theres no extra take for the 3rd player.

Screenshot 2024-11-20 000149 Screenshot 2024-11-19 235822

MichalD96 commented 2 days ago

Value never changed, because you set only 3 stacks of gold, which is exactly 2 bags. That's not enough for 3 players. % counter is meant to be set independently, because in this way you can count more advanced scenarios as i described here. Look that on first image percentages sums to 115%, so you need to decrease leader cut by 15% and you get real value.

antonyblinker commented 2 days ago

Ohh Im so sorry I didnt notice that. But why it doesnt correct the cut automatically? I mean the leader cut

MichalD96 commented 1 day ago

It was correcting leader cut, but somebody requested that change a while ago. I can add it back.

antonyblinker commented 1 day ago

It was correcting leader cut, but somebody requested that change a while ago. I can add it back.

I see. And thanks for the service :)