search

MichalGniadek / klask

Automatically create GUI applications from clap3 apps
MIT License
376 stars 23 forks source link

File chooser hangs on Mac OS #27

Closed alexjago closed 2 years ago

alexjago commented 2 years ago

Hi,

The file chooser currently hangs on Mac OS. This is probably downstream from https://github.com/balthild/native-dialog-rs/issues/23

Happily, it looks like they've fixed that, or at least made progress on it, as of version 0.6.2 — so upgrading the dependency version is hopefully all that's needed.

MichalGniadek commented 2 years ago

Hi, I have updated some dependencies. I don't have a mac to try it on, so could you try changing your cargo.toml to contain klask = { git = "https://github.com/MichalGniadek/klask"} and see if it still hangs?

alexjago commented 2 years ago

That seems to work as expected in my app! Thank you.

Please feel free to ping me whenever you'd like to test klask on Mac.

(P.S. clap is already up to 3.0.5 3.06 from 3.0.0)

MichalGniadek commented 2 years ago

Yeah, I know, but I think there is some kind of bug with non-ascii struct field names with clap <3.0.0. I didn't get around to making an issue on clap yet, so I just kept it at 3.0.0.

alexjago commented 2 years ago

Fair enough. I'll close this issue - looks like it's fixed.