search

MichalLytek / class-transformer-validator

A simple plugin for class-transformer and class-validator which combines them in a nice and programmer-friendly API.
MIT License
200 stars 19 forks source link

IsNumberString returns false for none integers #10

Closed AmirSasson closed 6 years ago

AmirSasson commented 6 years ago

such as "-0.8" a valid numeric string, i get an error. seems like the regex used to validate that missing a dot

MichalLytek commented 6 years ago

This is the regex: https://github.com/chriso/validator.js/blob/master/src/lib/isNumeric.js

If you think it's buggy, create an issue or PR on validator.js repository.

AmirSasson commented 6 years ago

submitted a PR to validator JS