Migrate subscriptions engine to graphql-yoga

MichalLytek / type-graphql

Create GraphQL schema and resolvers with TypeScript, using classes and decorators!

https://typegraphql.com

MIT License

7.99k stars 674 forks source link

Migrate subscriptions engine to graphql-yoga #1578

Closed MichalLytek closed 6 months ago

MichalLytek commented 8 months ago

use @graphql-yoga instead of graphql-subscriptions as the subscriptions engine
require providing PubSub implementation into buildSchema option when using @Subscription
remove @PubSub in favor of directly importing created PubSub implementation
remove Publisher and PubSubEngine types
add support for dynamic topic id function in @Subscription decorator option

carlocorradini commented 7 months ago

@MichalLytek Awesome.

What is missing?

MichalLytek commented 7 months ago

@carlocorradini Fixing pipeline issues, upgrading redis subscriptions example.

carlocorradini commented 7 months ago

Can I help somehow? ☺️

carlocorradini commented 7 months ago

@MichalLytek See PR #1590 🤗🥳

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0ad04ab) 95.52% compared to head (f5aa0d0) 95.50%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1578 +/- ## ========================================== - Coverage 95.52% 95.50% -0.02% ========================================== Files 113 113 Lines 1854 1848 -6 Branches 367 364 -3 ========================================== - Hits 1771 1765 -6 Misses 83 83 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.