search

MichalStrehovsky / iltrim

MIT License
9 stars 1 forks source link

Fix ConstructedType for generic base types #82

Closed sbomer closed 2 years ago

sbomer commented 2 years ago

The test doesn't pass yet but @agocke here's the change so far.

sbomer commented 2 years ago

I still haven't figured out the issue that is causing the test failure (some ctors aren't being kept in the output even though we seem to be writing calls to them). I'm done for now but I pushed a change I made that exposes different log options in case it's helpful to anyone.

MichalStrehovsky commented 2 years ago

I still haven't figured out the issue that is causing the test failure (some ctors aren't being kept in the output even though we seem to be writing calls to them)

The problem was that the ctor call are calls to a MemberRef token for the case of "ctor on an instantiated generic type". We were not putting the right things into the graph to make those MemberRefs resolvable.