MichalZalecki / react-portal-universal

Generic wrapper for React's createPortal allowing for rendering portals on the server
ISC License
65 stars 13 forks source link

Fix type error during build #7

Closed sanniassin closed 5 years ago

sanniassin commented 5 years ago

This PR fixes the following error during build: src/index.ts(28,110): error TS7006: Parameter 'node' implicitly has an 'any' type.

MichalZalecki commented 5 years ago

@sanniassin I see any and this makes me question merging https://github.com/MichalZalecki/react-portal-universal/commit/fe63446cd9c86d29561af2fc25c49791d0d165b0. IE11 😞. Can you make is an Element instead of any? I'll be happy to merge it.

sanniassin commented 5 years ago

@MichalZalecki Done