MicheleBertoli / css-in-js

React: CSS in JS techniques comparison
http://michelebertoli.github.io/css-in-js/
MIT License
5.53k stars 288 forks source link

I would like to include some more features #9

Closed kof closed 6 years ago

kof commented 9 years ago

Also I would add below a description for each feature.

MicheleBertoli commented 9 years ago

hey @kof,

adding some columns and descriptions would help. For example, it would be nice to know if a package supports the server-side rendering or not.

In general, I would prefer to keep the table as minimalistic as possible listing just the "key" features. In my opinion, the most important things are the code examples for each package.

For people who wants a massive list of features the Radium's one is perfect.

kof commented 9 years ago

Well, how do you know what a key feature is and what not) it depends on use case. I thought the intent is to compare those components from all possible aspects.

MicheleBertoli commented 9 years ago

You are right, @kof I just think that if the columns are too many, the table becomes less useful ;)

kof commented 9 years ago

Yes, we need a better format.

HighOnDrive commented 9 years ago

There should also be a column for solutions that work outside of React, like the exceptional JSStyles API. Being bound to only one framework is automatically not that great.

MicheleBertoli commented 8 years ago

We would need an interactive page, like: http://reactcheatsheet.com/

rtsao commented 8 years ago

@HighOnDrive agreed on having another column that indicates whether React is a dependency or not.

@MicheleBertoli I would be interested in helping create the interactive page (presumably to be hosted on a gh-pages branch for this repo?).

It would be nice to have a comprehensive table that isn't https://github.com/FormidableLabs/radium/tree/master/docs/comparison which IMHO is patently biased towards Radium's css-in-js implementation and is littered with unhelpful platitudes such as "same pitfalls as CSS."

MicheleBertoli commented 8 years ago

That would be awesome @rtsao.

robinweser commented 8 years ago

If there's something I can help you with, just text me :) I'd love to have a rich and dynamic comparison page. @MicheleBertoli

I also think @kof s arguments should be included somewhere as they are quite important features.

I think it could also be helpful to have e.g. a list of other useful tools/repositories that help using inline styles, but are not actually a discrete CSS in JS solution but rather used in combination with one.

MicheleBertoli commented 8 years ago

Sounds great @rofrischmann.

I'll be more than happy to create a web app all together. Are you still in @rtsao?

@kof's feature are very important, we just need something better than a table to show them.

rtsao commented 8 years ago

@MicheleBertoli Yes, I'm down!

MicheleBertoli commented 8 years ago

Here we go @rofrischmann @rtsao

Gitter

robinweser commented 8 years ago

Short update @kof @MicheleBertoli I have started drafting a simple interactive, responsive listing. I will push a first version soon :P

MicheleBertoli commented 8 years ago

awesome @rofrischmann, thanks! can't wait to see it :)

robinweser commented 8 years ago

We should perhaps also shoutout to all the owners to add additional information soon. ;)

tomByrer commented 8 years ago

I hope to see it soon; about to build a new tech stack from scratch, so the extra info will help.

kof commented 8 years ago

added "rendering technics" to the description

robinweser commented 8 years ago

I was kind of busy lately, will push the page by the end of the week hopefully.

MoOx commented 8 years ago

Having a column to say if a lib is compatible with react native would be nice (eg: react-look does via react-look-native).

Kielan commented 8 years ago

@rofrischmann if you have any progress feel free to push it in a separate repo and someone can maybe help you out.

Is there no list of reserved keys for this project available to developers? I am looking for the equivalent to transition-delay I assumed it would be transitionDelay: '0.2s',

robinweser commented 8 years ago

Finally pushed first table implementation. One can sort by clicking column headers, search by package names and filter requirements. Still we need to improve the UX/UI as it basically is ugly right now, but it works. Also I will add a mobile-friendly version soon, but first I guess we now need all the data for all the packages. Basically a simple PR with changes to https://github.com/MicheleBertoli/css-in-js/blob/webpage/data.js would do the job. I will add a static build as more data is added so we can push to ghpages.

Also I will add some column descriptions, credits etc.

buildbreakdo commented 8 years ago

Some pretty big items missing from this like:

robinweser commented 8 years ago

I guess we can merge the first 2 and just call it XSS vulnerability? The others seem to be fine. I may add those later on :) Thank you @buildbreakdo

stereobooster commented 7 years ago

How about push existing version + every undefined value mark in table as grey area e.g. unknown. After working version will be online it will be fastly populated by volunteers

stereobooster commented 6 years ago

New version of website https://github.com/MicheleBertoli/css-in-js/pull/58

stereobooster commented 6 years ago

I want to add more columns to https://stereobooster.github.io/css-in-js/ and I thought it would be nice actually define what each feature mean, illustrate it with example, show advantages disadvantages of each approach. So I started this repo https://github.com/stereobooster/css-in-js-systematic-approach/ cc @markdalgleish

Small correction: @import is open to CSRF, not XSS

MicheleBertoli commented 6 years ago

🎉 http://michelebertoli.github.io/css-in-js/ 🎉 Thanks @stereobooster

stereobooster commented 6 years ago

Almost finished polishing of "CSS-in-JS 101"

css-in-js

As soon as we agree on terminology. I want to start to add more features (columns) to table.

MicheleBertoli commented 6 years ago

I'm closing this in favor of #73