Update google-maps.js - Githubissues

MicheleBertoli / react-gmaps

A Google Maps component for React.js

http://react-gmaps.herokuapp.com/

MIT License

317 stars 68 forks source link

Closed dgrodrigues closed 7 years ago

dgrodrigues commented 7 years ago

added validation for window.google.maps, to prevent problems with another google libs.

MicheleBertoli commented 7 years ago

Thanks for your PR, @dgrodrigues.

Can you please remove the comment and change the condition to:

if (window.google && window.google.maps) {

Otherwise is going to fail if google doesn't exist.

MicheleBertoli commented 7 years ago

Fantastic @dgrodrigues, you should just fix the failing test before merging please. You can run the tests locally with npm test. Thanks!

MicheleBertoli commented 7 years ago

Closing this in favour of #75. Thanks @dgrodrigues.