search

MicheleNuijten / statcheck-web

MIT License
2 stars 0 forks source link

Build in support for new version of statcheck #24

Closed WillemSleegers closed 2 years ago

WillemSleegers commented 2 years ago

Add support for the new version of statcheck so this app won't break when the new version of statcheck is released.

The most important change will be the names of the columns in the statcheck results, so let's add in code to check which names are in the data frame and change accordingly.

MicheleNuijten commented 2 years ago

Done: see the branch compatibility-new-statcheck. I checked it on my computer with both the statcheck version on CRAN and the new version, and both seem to work. If it works for you, this branch can be merged with main.

WillemSleegers commented 2 years ago

Hm can you copy the fix-ui-issues branch and implement the change there? That should result in simpler code. Now the renaming happens in 2 different functions.

WillemSleegers commented 2 years ago

I added it to the fix-ui-issues brand and also adapted it so we don't need to rely on the dplyr package.