search

MichelePalmieri / grav-piwik-plugin

Piwik/Matomo plugin lets you embed the tracking to the Grav website.
MIT License
11 stars 1 forks source link

Improved Piwik embed code #5

Closed geschke closed 7 years ago

geschke commented 7 years ago

Hello!

I've taken the JavaScript code from a newer Piwik installation to support both http and https protocols. In Piwik's JavaScript code only the server name is needed, so I've stripped the protocol out of the code. For compatibilty reasons the protocol is cut if it is submitted in the configuration.

It would be nice if it could be included in the next version. Thanks in advance & Kind regards, Ralf

phideas commented 7 years ago

I am not sure it is a good idea to remove 'http' or https' prefix from site ID. We are selfhosting Piwik and our tracking code requires site ID including protocol prefix.

geschke commented 7 years ago

Please have a look at a current version of Piwik. I'm running self-hosted Piwik 3.0.1 and have taken the embed code from this version. See the line below:

var u="//analytics.mushaake.org/";

The advantage of this method is, that it is working with both protocols http and https without predefining the used protocol. Piwik is available with http and https, so it runs in every case. The browser uses the protocol which is used on the main site.

phideas commented 7 years ago

Thank you for your response. Didn't know about this option. Still new to Piwik. In this case it is totally fine. Anyway, thanks for updating this plugin for Grav.

MichelePalmieri commented 7 years ago

done

geschke commented 7 years ago

Thanks for merging! I'm glad to see that you're active here again! Just a question regarding my request to take over the plugin. I never wanted to take over the plugin against your wishes, but it seemed that you didn't working anymore on this code. So if you want to keep the code in your repository, I will cancel my request.

Kind regards and thanks for writing the plugin!

Ralf

MichelePalmieri commented 7 years ago

Sorry for my English. There is no problem to give you the plugin. I shared the plugin

MIK