Sort by Timestamp or Rating in SearchRecipes (and Feed?)

MichielProost / Perfect-Plate

This Android application allows cheffs around the world to create, review and discover new recipes. Users can gain experience and level up in this app by completing challenges like creating a certain amount of recipes.

1 stars 2 forks source link

Sort by Timestamp or Rating in SearchRecipes (and Feed?) #15

Open MichielProost opened 3 years ago

MichielProost commented 3 years ago

The method searchRecipes in RecipeService allows the user to store recipes by their timestamp or rating. Yet, I think we forget to implement this in the search UI.

I don't know if we should implement this for feed? It would be nice to, for example, view the newest recipes (sort by timestamp).

Nuytemans-Dieter commented 3 years ago

I left that out intentionally. If needed, it can perhaps be considered as a v2 feature?

MichielProost commented 3 years ago

Why did you leave it out? Stop me if I'm wrong, but I think this was included in the specifications. Perhaps miscommunication. Since our exams are getting closer, I'm going to let you decide whether to include this in v1. If not, I think we should include this in one of the future updates.

Ps. We can sort recipes based on weightedRating, rating and timestamp. We don't use rating at the moment. I will keep it in for future updates (although it causes us to have a lot of indexes)

Nuytemans-Dieter commented 3 years ago

Why did you leave it out? Stop me if I'm wrong, but I think this was included in the specifications. Perhaps miscommunication. Since our exams are getting closer, I'm going to let you decide whether to include this in v1. If not, I think we should include this in one of the future updates.

Ps. We can sort recipes based on weightedRating, rating and timestamp. We don't use rating at the moment. I will keep it in for future updates (although it causes us to have a lot of indexes)

I feel like it is only a small addition for the cost of another field in the UI. Any added field results in more clutter and a harder to understand form. This seems like a better choice for a later release, if decided to implement it.

MichielProost commented 3 years ago

Let's discuss this issue a bit more.. Down below is a list of questions:

Would this be a difficult feature to implement in the UI?
Do you want to implement this feature?
Where should we implement this feature?

My answer to the second and third question:

Definitely! I think this would be a great addition. It allows the user to explore our database in a variety of ways. Let's say we have 100 recipes in our database. Most likely, the same recipes will appear in the top our feed. With sorting, the user can search for recently made recipes, maybe sort on the amount of comments they received and so on.
Wherever we fetch recipes. Giving this option by default is definitely the way to go.

Nuytemans-Dieter commented 3 years ago

It is not hard to add (looks-wise), but it should fit in the UI and look good which can be a challenge. Right now I'm thinking about a dropdown menu that can perform sorting. The easiest way is to use the back-end for sorting if those indexes are still set. For cached results, the sorting should be handled locally (not in the cloud).
At some time in the future, yes.
I'd think wherever recipes are displayed: search, profile screen and the feed.

The only problem I see is the search field (search screen). It is becoming too bulky in my opinion so we'll have to figure something out there.

MichielProost commented 3 years ago

Yes. The indexes are still available. You can sort recipes on their rating, weightedRating and timestamp. I've made the indexes, so that the recipes always appear in a descending order (e.g. heighest rating on top).
Agreed.

The search field is definitely the most complicated to keep clean. I'm right here if you need a listening ear!