Closed jishnub closed 2 years ago
Merging #105 (48fca80) into master (ca6f2ad) will decrease coverage by
0.06%
. The diff coverage is89.18%
.
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
- Coverage 90.36% 90.30% -0.07%
==========================================
Files 10 10
Lines 758 784 +26
==========================================
+ Hits 685 708 +23
- Misses 73 76 +3
Impacted Files | Coverage Δ | |
---|---|---|
src/kroneckerpowers.jl | 89.65% <75.00%> (-3.53%) |
:arrow_down: |
src/base.jl | 92.72% <100.00%> (+0.25%) |
:arrow_up: |
src/vectrick.jl | 94.81% <100.00%> (+0.11%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ca6f2ad...48fca80. Read the comment docs.
gentle bump, would be nice to have this
Sorry, lost in the pile of unread emails. Great job!
These methods avoids allocations while multiplying diagonal matrices:
On master:
After this PR:
There's also an optimized
diag
for square matrices, using the Kronecker product of the diagonals.Also fixed certain method ambiguities in multiplications with triangular matrices.