codecov-commenter
commented
1 year ago Codecov Report
Patch coverage has no change and project coverage change: -0.02 :warning:
Comparison is base (
36e37c7) 91.59% compared to head (dbb41f4) 91.58%.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #125 +/- ## ========================================== - Coverage 91.59% 91.58% -0.02% ========================================== Files 11 11 Lines 821 820 -1 ========================================== - Hits 752 751 -1 Misses 69 69 ``` | [Impacted Files](https://app.codecov.io/gh/MichielStock/Kronecker.jl/pull/125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michiel+Stock) | Coverage Δ | | |---|---|---| | [src/vectrick.jl](https://app.codecov.io/gh/MichielStock/Kronecker.jl/pull/125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Michiel+Stock#diff-c3JjL3ZlY3RyaWNrLmps) | `94.53% <ø> (-0.05%)` | :arrow_down: |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This addresses #124
The problem was that Kronecker products of diagonal matrices are transformed too eagerly in
Diagonaltypes. I fixed this by making the methods less general. This had the issue that it errors in a couple of test cases when the mixed product property is non-conformable. Within the philosophy of Kronecker.jl, it is your responsibility to fix this, e.g. by making one of the matrices dense.