FB_RS485_EASTRON_SDM_POWER_MQTT: Adding support for SDM120

MichielVanwelsenaere / HomeAutomation.CoDeSys3

Home Automation system build in CoDeSys 3 with MQTT communication to any third party Home Automation software

MIT License

112 stars 37 forks source link

FB_RS485_EASTRON_SDM_POWER_MQTT: Adding support for SDM120 #127

Closed MichielVanwelsenaere closed 1 year ago

MichielVanwelsenaere commented 1 year ago

Pull Request Checklist

Check if the tasks below are relevant for your PR, to mark an item as completed use [X].

[X] Updated the PLCOpen XML export file (only relevant on code change).
[X] Updated the CoDeSys V3 export file (only relevant on code change).
[X] Updated or created any relevant documentation.

Proposed Changes

Adds support for the Eastron SDM120 on FB_RS485_EASTRON_SDM_POWER_MQTT

Related issues

Closes #125

meijer3 commented 1 year ago

Yes, it works. Thanks!

meijer3 commented 1 year ago

Only what confuses me is the home-assistant config

` - topic: "Devices/PLC/House/Home/Out/RS485/FB_RS485_EASTRON_SDM_POWER_001/availability"

topic: "Devices/PLC/House/availability" The first topic hasHome` in the topic. That is not the case in the/my POU. I didnt check if it was on purpose, but I changed the config. It is also in your SDM220 markdown I noticed

MichielVanwelsenaere commented 1 year ago

Only what confuses me is the home-assistant config

- topic: "Devices/PLC/House/Home/Out/RS485/FB_RS485_EASTRON_SDM_POWER_001/availability" - topic: "Devices/PLC/House/availability" The first topic has Home in the topic. That is not the case in the/my POU. I didnt check if it was on purpose, but I changed the config. It is also in your SDM220 markdown I noticed

good catch, a leftover from a refactor on the topic approach. Fixed!