Michsior14 / ha-venta

Home assistant integration for Venta devices
MIT License
11 stars 6 forks source link

docs: add AH535 #41

Closed helgek closed 7 months ago

helgek commented 7 months ago

added missing black color AH535

Michsior14 commented 7 months ago

Do you know by any chance the device id for AH535? Also if you can update info.md it would be great.

helgek commented 7 months ago

Unfortunately not, I only have the AH510.

Michsior14 commented 7 months ago

Ah! So it's not tested that it works? In general the devices are added to the readme once someone confirms it works and reports device id.

helgek commented 7 months ago

Correct, I had just assumed you may have forgotten to add it since it's only a colour variant of the AH530, so assuming it's the same data. But it might have a different device id of course to distinguish it from the AH530. I didn't check what this looks like for the other models.

bhuebschen commented 7 months ago

regarding the current version of the venta-app (2.1.1), the maximum device-id is 500 (id of AH500) if there is any device > 500, it will be detected as AH500

Michsior14 commented 7 months ago

regarding the current version of the venta-app (2.1.1), the maximum device-id is 500 (id of AH500) if there is any device > 500, it will be detected as AH500

Did you maybe find anything regarding the mentioned device in the app sources?

bhuebschen commented 7 months ago

regarding the current version of the venta-app (2.1.1), the maximum device-id is 500 (id of AH500) if there is any device > 500, it will be detected as AH500

Did you maybe find anything regarding the mentioned device in the app sources?

public static DeviceSeries SeriesFromModel(DeviceModelId deviceModelId)
{
    DeviceSeries result = DeviceSeries.Undefined;
    if (deviceModelId <= DeviceModelId.AS100)
    {
        if (deviceModelId - DeviceModelId.LP60 <= 5)
        {
            return DeviceSeries.AppControl;
        }
        if (deviceModelId - DeviceModelId.AP902 <= 2)
        {
            return DeviceSeries.Professional;
        }
        if (deviceModelId != DeviceModelId.AS100)
        {
            return result;
        }
    }
    else if (deviceModelId <= DeviceModelId.LP74)
    {
        if (deviceModelId - DeviceModelId.LW73 > 1 && deviceModelId - DeviceModelId.LP73 > 1)
        {
            return result;
        }
        return DeviceSeries.Aerostyle;
    }
    else if (deviceModelId != DeviceModelId.AS150)
    {
        if (deviceModelId != DeviceModelId.AH500)
        {
            return result;
        }
        return DeviceSeries.OriginalConnect;
    }
    result = DeviceSeries.AirSense;
    return result;
}

and the Enum i posted in my PR

bhuebschen commented 7 months ago

But i also found a lot of usefull informations in json-files that are bundles with the app .. these files contain properties of each device type including an description of the properties

I sent you an email with the files

Michsior14 commented 7 months ago

But i also found a lot of usefull informations in json-files that are bundles with the app .. these files contain properties of each device type including an description of the properties

I sent you an email with the files

Oh, those files are great help! Thanks. I see we made couple of assumptions that are completely wrong ;)