search

MickaelRigault / astrobject

This module gather the basic tools one usually needs in astrophysics and cosmology
6 stars 4 forks source link

Fitter class #41

Open ufeindt opened 8 years ago

ufeindt commented 8 years ago

To assess lightcurve quality, I'll get started on a fitter class that collects the fits and makes plotting them easy. I have some code like that already from the lc simulations I ran a year ago in Berlin, just need to make it consistent with astrobject.

I'll keep the fitter separate from other objects for now because we may want to run different fitters on the same set of simulated lcs, e.g. to test photmetric typing.

MickaelRigault commented 8 years ago

Hi Uli,

I left this fitter in astrobject. I think it makes more sense this way. Remark that we may want to call it LCFitter or SNLCFitter to make sure it is clear that it is actually a lightcurve fitter

Cheers

ufeindt commented 8 years ago

Good point, I'll change it to LCFitter I think because in principle it shouldn't be limited to SNe. (I might also add a child SNIaFitter or SALT2Fitter that has some extra stuff for Ia's)

MickaelRigault commented 8 years ago

sounds perfect

On Sun, May 8, 2016 at 1:47 PM, Ulrich Feindt notifications@github.com wrote:

Good point, I'll change it to LCFitter I think because in principle it shouldn't be limited to SNe. (I might also add a child SNIaFitter or SALT2Fitter that has some extra stuff for Ia's)

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/MickaelRigault/astrobject/issues/41#issuecomment-217711203