search

MickeyKay / better-font-awesome-library

[WordPress] The easiest way to integrate Font Awesome into your WordPress theme or plugin.
34 stars 13 forks source link

CDN Assets Have Moved #22

Closed cgrymala closed 4 years ago

cgrymala commented 5 years ago

If you look at https://github.com/FortAwesome/Font-Awesome/blob/master/UPGRADING.md#550-to-560 you'll see that the CDN assets have moved since this library was last updated. Instead of the icons.yml file being located in advanced-options/metadata/icons.yml it's now located at metadata/icons.yml, which is causing this library not to be able to locate the icon data.

As far as I can tell, the only change that needs to be made is to modify https://github.com/MickeyKay/better-font-awesome-library/blob/master/better-font-awesome-library.php#L70 from:

    const JSDELIVR_ICON_METADATA_FILE_PATH = '/advanced-options/metadata/icons.yml';

to:

    const JSDELIVR_ICON_METADATA_FILE_PATH = '/metadata/icons.yml';

Thanks.

cgrymala commented 5 years ago

Actually, since it only moved after v5.5.0, it would probably need to do some sort of version comparison before defining the constant.

MickeyKay commented 4 years ago

@cgrymala Wow, juuuuust seeing this. So sorry for the delay my friend :( On the positive side, though, I'm happy to announce I've got a PR in the works to fix #allthethings, and simply use the latest version of FA always. I'd love your eyes if you have a moment: https://github.com/MickeyKay/better-font-awesome/pull/17