search

MickeyKay / better-font-awesome

[WordPress] A WordPress plugin that allows you to easily integrate the latest version of FontAwesome.
GNU General Public License v2.0
10 stars 7 forks source link

Fixes Font Awesome 5 URLs --- Fixes jQuery error to be compatible with WordPress 5.5 #16

Closed aebs90 closed 3 years ago

aebs90 commented 4 years ago

Fixes a jsDelivr API error due some URLs have changed since the last update of better-font-awesome-library

After applying this fix, the error from the following image disappears:

image

--

I'm not sure if it's correct to edit code from the vendors directory or if we should update the code on the better-font-awesome-library first and then update the version of that library here. Any suggestion is really appreciated.

Finally, I have access to the WordPress Directory Plugins repository, but I'm not sure "how to clean the files" to upload only the "compiled" version of the plugin. I'm not very experienced with composer.

aebs90 commented 3 years ago

Fixed a jQuery bug that appeared on WordPress 5.5

MickeyKay commented 3 years ago

Thanks so much for your input @aebs90, and I'm glad to report that I've actually got a WIP PR in to actually resolve all these outstanding issues with a full cutover to the Font Awesome GraphQL API. I'd love your 👁️ if you have time: https://github.com/MickeyKay/better-font-awesome/pull/17

MickeyKay commented 3 years ago

Closing this out as I just shipped v2.0.0 which should handle all of this.