search

MickeyKay / better-font-awesome

[WordPress] A WordPress plugin that allows you to easily integrate the latest version of FontAwesome.
GNU General Public License v2.0
10 stars 7 forks source link

Handle true/false as booleans #29

Closed szepeviktor closed 3 years ago

MickeyKay commented 3 years ago

Hi @szepeviktor. Can you please provide some context on this PR? What's the problem you're seeking to solve?

szepeviktor commented 3 years ago

It makes 1 line from 5 as is_readable already returns a boolean.

MickeyKay commented 3 years ago

Is there a specific problem this solves? I see tests are now failing, and I wouldn't have thought that this should functionally change anything. Can you please run tests locally and fix and issues? npm run develop && npm run test should get you what you need.

szepeviktor commented 3 years ago

Can you please run tests locally and fix and issues?

PHPCS finds that better-font-awesome.php is not written in WPCS. This has nothing to do with this PR.