Closed justice47 closed 5 years ago
You must merge the GitHub pages demo branch to here, aside from this.
You must merge the GitHub pages demo branch to here, aside from this.
Hi! How can I make this? I can only make a PR, demo page made as a standalone vue app, so should I make PR to some branch inside main project (vue-materialize-datatable)?
@justice47 Hi, sorry for the delayed response, I read the email and forgot to reply.
Yes, you make a branch called gh-pages
, push stuff there and make a PR for it. Make sure to include source and not just compiled files, as well.
@MicroDroid no problem! I've created new branch in my fork of vue-materialize-datatable, but then I'm trying to make a PR to your master branch, github shows message: "There isn’t anything to compare. MicroDroid:master and justice47:gh-pages are entirely different commit histories." I think you should create empty branch, and then I can push gh-pages branch to it.
Alright created the branch, try now see if it works.
Wait this wouldn't work, uhh, will have a further look in a little while
@justice47 Hey there, you can put everything in docs/
folder with the master
branch be done with it, no need for extra branches. Just push changes to this PR maybe.
Now for the source, maybe put it in a directory outside docs/
, no idea where just find something appropriate, and put compiled stuff in docs/
so I configure GitHub to serve from it.
Thanks for everything and sorry for BIG delays.
@MicroDroid hi! I've added docs dist and docs src in new commit.
heh I'm too lazy to review this PR.
I'll blindly merge it; I hope it works well enough :eyes:
Alright there were a few issues, got rid of them and fixed them up. It's up now on https://microdroid.github.io/vue-materialize-datatable/
Thanks a lot @justice47!