search

MicroDroid / vue-materialize-datatable

A fancy Materialize CSS datatable VueJS component.
https://overcoder.dev/vue-materialize-datatable
MIT License
179 stars 67 forks source link

Added default column sort prop #42

Closed justice47 closed 5 years ago

justice47 commented 5 years ago

Based on #26 issue

MicroDroid commented 5 years ago

Great, I'll take a look very soon.

On Mon, Jul 15, 2019 at 2:53 PM justice47 notifications@github.com wrote:

Based on #26 https://github.com/MicroDroid/vue-materialize-datatable/issues/26 issue

You can view, comment on, or merge this pull request online at:

https://github.com/MicroDroid/vue-materialize-datatable/pull/42 Commit Summary

  • changes to README, added demo button
  • few markdown tests
  • few markdown tests
  • few markdown tests
  • few markdown tests
  • few markdown tests
  • few markdown tests
  • few markdown tests
  • few markdown tests
  • few markdown tests
  • few markdown tests
  • few markdown tests
  • few markdown tests
  • few markdown tests
  • few markdown tests
  • few markdown tests
  • few markdown tests
  • few markdown tests
  • few markdown tests
  • few markdown tests
  • switch double quotes to single quotes
  • added docs dist and docs src
  • merged with actual original
  • sync with dev changes - initial sort by second column + new table body slot
  • added default sorting option
  • made some changes for pr
  • some changes for pr
  • some changes for pr

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MicroDroid/vue-materialize-datatable/pull/42?email_source=notifications&email_token=ACBA274R474H3OD2CZS4UKTP7RQKBA5CNFSM4IDV7DZ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G7GM7VQ, or mute the thread https://github.com/notifications/unsubscribe-auth/ACBA275XZJJXSC4MXQJTCHDP7RQKBANCNFSM4IDV7DZQ .

MicroDroid commented 5 years ago

Alright I haven't tested this cause webpack went jank and I'm too tired for this :roll_eyes:

I'll rely on your testing, the changes seem fine to me, but please add detailed documentation for this in README, and I'll merge this.

MicroDroid commented 5 years ago

Thanks a lot!