search

MicroDroid / vue-materialize-datatable

A fancy Materialize CSS datatable VueJS component.
https://overcoder.dev/vue-materialize-datatable
MIT License
179 stars 67 forks source link

Table responsiveness #50

Closed TimothyMee closed 4 years ago

TimothyMee commented 4 years ago

PR #47 had some issues that needed to be fixed. This commit fixes those issues.

MicroDroid commented 4 years ago

This is still a bad solution. How would the plugin user determine the table needs to be responsive or not?

Usually you just want to put data and suddenly "it works"

TimothyMee commented 4 years ago

Exactly my thought with the previous solution, the user shouldn't have to worry about the responsiveness, it should be out of the box. But in your comment to the previous solution, you stated that the responsiveness

"should be entirely optional"

Except I misunderstood.

I thought about it and handing control of the table responsiveness to the plugin user isn't such a bad idea.

As a user, I might decide to just use bootstrap's "table-responsive" on the parent div and not want the table provided responsiveness.

MicroDroid commented 4 years ago

Ah no, what I meant by that rather is the scrollbar should show up or not automatically as data requires.

i.e. if the columns are too jambled that it can't fit, a scrollbar should show and the table should stop shrinking. We also need a way to handle rows with exceedingly large data somehow, or we could leave truncating up to the user?

It requires a bit of thought to get this right but I am not exactly free in the meantime to work on fixing this.

I'd appreciate any thoughts you may have.

TimothyMee commented 4 years ago

Ohh Ok. I will look into that.