search

MicroFocus / alm-octane-js-rest-sdk

NodeJS wrapper for the Micro Focus ALM Octane API
Other
9 stars 14 forks source link

Proxy set if explicitly given. The requestor handles the evn variables. #33

Closed XtraSonic closed 4 years ago

XtraSonic commented 4 years ago

The request library handles the HTTP(S)_PROXY variables as well as the NO_PROXY variable. We should set the proxy only if explicitly given as a parameter because otherwise all the requests will contain that proxy whether it should actually be used or not. Tested when HTTPS_PROXY exists and octane both needs and doesn`t need a proxy. Also tested the case when a different proxy is needed to reach Octane (not the one specified in HTTPS_PROXY) and when no HTTPS_PROXY is used and the proxy is explicitly given.
Explicitly giving the proxy overrides the any proxy that is(or not) set in the env variables.

slbruce commented 4 years ago

@XtraSonic can you merge and close?