MicroHealthLLC / mSuite

Real Time Collaboration Made Simple for concept maps, kanban, documents and spreadsheets.
4 stars 1 forks source link

Notepad: Improved Synchronous editing and typing #1798

Open MaxVMoons opened 7 months ago

MaxVMoons commented 7 months ago

Improved the updating of the document so that when a user receives an update, what they have typed does not disappear. However, when multiple people edit/type in the same spot, it will take the latest edit(s)/typed character(s) and replace the earlier ones.

Currently found problems: Two people pasting an image within a single update, no negative effect on the rest of the document, it will keep the earlier pasted picture and location. Two people abusively using line affecting buttons (picture attached) on the same line within a single update, sometimes will work correctly and other times the sync will delete one of the button presses. image Two people using the bold, italics, underline, or strikethrough (and assumingly other character specific button edits) on overlapping characters within a single update, only one of the edits goes through and seemingly randomly either one, no negative effect on non-selected parts of the document. If someone deletes characters where (and past where) someone else has their cursor, then the second person's cursor will go further back than necessary.

Multiple people typing a lot at the same time needs to be tested.

MaxVMoons commented 7 months ago

Dev does not connect websockets so testing will begin when pushed to qa env.

MaxVMoons commented 7 months ago

Stabilization needed: when sending the data back and forth between users, edits in that time are undone, also affecting the cursor location to type not where their cursor should be. Maybe due to many delayed update calls or, more likely, typing at the exact same time causes the updates to think they are complete but not so, can add a timer to the wipe of memory variable.