The spec spends a fair amount of time explaining the advantages of the witness discount and the Ord/Rodarmor "envelope" OP_FALSE OP_IF ... construction, but then uses OP_RETURN instead for creation. This doesn't seem that well motivated in the spec. (I did separately PR #8 to add the word 'envelope' which is IIUC correct-er that ordinal/inscription, if you're just borrowing the taproot script bit)
I think it'd be good to explicitly detail why this is done for those less familiar?
Envelopes work but require two transactions (1st tx commits to the tapscript, 2ns spends to reveal the script so the envelope can be read) whereas OP_RETURN is one-and-done
The Batch Create section gives a table with vBytes for various batch sizes, this could also list the equivalent "what if you did them one by one" vByte cost to illustrate the savings from batching
Also given that Batch Creation uses a different mechanism (the did flag is in the revealed envelope, there's no OP_RETURN if I understand correctly) it may be simpler overall to have that be the only creation mechanism and drop the OP_RETURN? (I'm not that sure of the cost diff, but I'd guess most non-batch DIDs are all going to get an update anyway to add useful stuff to the DID document, so that could be done up-front)
The spec spends a fair amount of time explaining the advantages of the witness discount and the Ord/Rodarmor "envelope"
OP_FALSE OP_IF ...construction, but then usesOP_RETURNinstead for creation. This doesn't seem that well motivated in the spec. (I did separately PR #8 to add the word 'envelope' which is IIUC correct-er that ordinal/inscription, if you're just borrowing the taproot script bit)I think it'd be good to explicitly detail why this is done for those less familiar?
OP_RETURNis one-and-doneAlso given that Batch Creation uses a different mechanism (the
didflag is in the revealed envelope, there's noOP_RETURNif I understand correctly) it may be simpler overall to have that be the only creation mechanism and drop theOP_RETURN? (I'm not that sure of the cost diff, but I'd guess most non-batch DIDs are all going to get an update anyway to add useful stuff to the DID document, so that could be done up-front)