search

MicroStrategy / did-btc-spec

did:btc Method Specification
https://microstrategy.github.io/did-btc-spec/
43 stars 12 forks source link

Incorrect `id` properties in examples #5

Closed brianorwhatever closed 2 months ago

brianorwhatever commented 5 months ago

In the DID document examples the id properties aren't correct. The top level id should be the DID itself and not just the txref. The other items are also incorrect as they use the txref instead of the DID as well.

sangaman commented 5 months ago

Thanks for catching this, that's right. It was just an oversight in my part when constructing the examples.

LeoBeb commented 2 months ago

I am closing this as it was addressed.

brianorwhatever commented 2 months ago

No it was not. The id parameter in the linked example is not a proper uri. It should be the did itself

LeoBeb commented 2 months ago

Reopening until the PR is approved and merged.

LeoBeb commented 2 months ago

Merged the changes from #14. If further changes are required, please create a new PR directly. Thank you.