search

MicronOxford / SIMcheck

SIMcheck: ImageJ tools for assessing Structured Illumination Microscopy (SIM) data quality and reliability
GNU General Public License v3.0
28 stars 5 forks source link

Exchanged parallel_FFTJ with JTransforms3 #31

Closed mueller-physics closed 6 years ago

mueller-physics commented 7 years ago

Fixed #29 (at least partially).

JTransforms is available on maven (license is BSD-2-Clause)

I don't know how to ensure that JTransforms and all dependencies are available when running as an ImageJ-plugin, though.

carandraug commented 7 years ago

I was checking JTransforms license and the projects it is based on with Marcel earlier today, and everything seems good as far as licences go. @graemeball if you can take a look at this and are happy with the results, I'm good with a 1.2 release that drops parallel FFTJ.

graemeball commented 7 years ago

Looks like this may be a good solution -- thanks Marcel for the work on this. I will check it out properly as soon as I can.

carandraug commented 6 years ago

Got confirmation from Lothar that he tested it and it works. Graeme is happy to merge it so it's done.

On 17 November 2017 at 13:08, Lothar Schermelleh lothar.schermelleh@bioch.ox.ac.uk wrote:

Hi Graeme, [...] I wanted to let you know, that I finally tested Marcel’s 3D-FFT implementation into SIMcheck. It generates identical results but without having to rely on Parallel FFTJ, but most importantly freeing us from any licencing troubles. If you have no objection, David is happy to push this as official version 1.1. Please confirm this to him. [...]

On 19 November 2017 at 08:07, Graeme Ball graemeball@googlemail.com wrote:

[...] I am very sorry I have not had a chance to sort out SIMcheck as I promised to do some months ago now -- I am happy for David to go ahead and release a "SIMcheck 1.1" including Marcel's 3D FFT [...]