search

Microsemi / switchtec-kernel

A kernel module for the Microsemi PCIe switch
GNU General Public License v2.0
45 stars 31 forks source link

switchtec: Fix unintended mask of MRPC event #52

Closed wesleywesley closed 5 years ago

wesleywesley commented 5 years ago

In case of two or more events happened simultaneously, MRPC event maybe masked which lead to no more interrupt for this event, before the next module remove and install. In this situation, polling in 500ms time interval instead of interrupt is leveraged, therefore the MRPC execution respond speed is lower down evidently.

Fix this issue by skip the mask operation same as LINK event.

Reported-by: Susan He susan.he@microchip.com Signed-off-by: Wesley Sheng wesley.sheng@microchip.com

kelvin-cao commented 5 years ago

If two events other than MRPC was generated at the same time. There's no such issue. The description is a little bit confusing.

I think this case is when a MRPC completion event and one or mor other events happened to be handled in the same interrupt handling, the MRPC completion would be disabled unintentionally. Since there's no chance to enable it again, all the following MRPC execution completion check will be defer to a timeout.

Add I'd also suggest add description of the problem we observed at the beginning.

wesleywesley commented 5 years ago

@kelvin-cao thx for comments. the commit message was updated.