search

MicrosoftDX / Dash

Data At Scale Hub (DASH). Virtual storage account aggregating scale limitations of individual accounts.
Other
37 stars 4 forks source link

storage key in source #1

Closed withinboredom closed 9 years ago

withinboredom commented 9 years ago

Just wanted to let you know, you have storage keys committed in the code: https://github.com/MicrosoftDX/Dash/blob/master/DashServer.Azure/ServiceConfiguration.Cloud%20-%20East.cscfg

jamesbak commented 9 years ago

Thanks for the notification.

The tests & configuration artifacts have now been refactored (as of commit: a4a6dfe) so that no secrets are kept in the source repo.

withinboredom commented 9 years ago

Welcome!

I realized how difficult it was to keep them out of SCM so I started googling common parts of connection strings and letting people know it was committed.