search

MicrosoftDX / Vorlonjs

A new, open source, extensible, platform-agnostic tool for remotely debugging and testing your JavaScript. Powered by node.js and socket.io
http://www.vorlonjs.com
Other
2.92k stars 259 forks source link

Use path.resolve instead of path.join for loading ssl options #437

Open mlucool opened 6 years ago

mlucool commented 6 years ago

This is a breaking change if your key/crt started with a '/'

path.join('/foo/bar', '../', 'baz') '/foo/baz' path.join('/foo/bar', '../', '/baz') '/foo/baz' path.resolve('/foo/bar', '../', 'baz') '/foo/baz' path.resolve('/foo/bar', '../', '/baz') '/baz'

mlucool commented 6 years ago

@meulta Any issues with this?