MicrosoftDocs / Advertising-docs

Creative Commons Attribution 4.0 International
15 stars 59 forks source link

Class name in comment would not compile #256

Closed codecadwallader closed 6 years ago

codecadwallader commented 6 years ago

There's a commented out example above:

// Alternatively you can request data for a subset of campaigns or ad groups. //Scope = new AccountThroughAdGroupReportScope //{ // AccountIds = null, // Campaigns = new[] { // new AdGroupReportScope // { // AccountId = accountId, // CampaignId = <YourCampaignIdGoesHere>, // AdGroupId = <YourAdGroupIdGoesHere> // } // } //},

However an AdGroupReportScope cannot be assigned to Campaigns.. this should be CampaignReportScope.

Thanks!


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

codecadwallader commented 6 years ago

or on further thought.. perhaps its intended to be assigned to AdGroupReports (instead of Campaigns). In that case the class name is right, its what the array is being assigned to that needs updated.

codecadwallader commented 6 years ago

In other words.. // AdGroups = new[] { // new AdGroupReportScope

eric-urban commented 6 years ago

@codecadwallader good catch thanks! Looks like a copy/paste error with the commented out code (compile didn't catch it). We've updated the sample in the SDK repository, and will update Docs next opportunity.

codecadwallader commented 6 years ago

Looks good, thanks for the quick turnaround!