search

MicrosoftDocs / CloudAppSecurityDocs

Public repo for CloudAppSecurityDocs-pr
Creative Commons Attribution 4.0 International
107 stars 155 forks source link

Update app-governance-visibility-insights-get-started.md #540

Closed anandd512 closed 2 years ago

PRMerger18 commented 2 years ago

@anandd512 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

dcurwin commented 2 years ago

@Court72 - Why was this PR merged? The author did not sign-off yet, and the content isn't ready to go live.

Court72 commented 2 years ago

Hi @dcurwin,

Note that you're listed as the author in the metadata for CloudAppSecurityDocs/app-governance-visibility-insights-get-started.md. Per the Public PR review process, a PR is ready to merge after the author or another trusted source signs off, approves the changes, or requests merge via the techdocprs alias.

If these changes need to be reverted, please do so in another PR.

Thanks!

dcurwin commented 2 years ago

@Court72 - I don't see anything in the article you linked to that indicates that if I approved, the author doesn't need to sign off. Where do you see that?

anandd512 commented 2 years ago

Hi @dcurwin and @Court72,

I thought the tag 'do-not-merge' was sufficient to ensure that this PR is not merged. Can you please help revert if it has been merged? Also, please let me know if there's any change I need to do to ensure this does not happen again -

If I need to be making changes to the private repo - can you please add me to that repo? If there's any other label that I should add to call out that the PR is not ready to get published?