MicrosoftDocs / PowerShell-Docs

The official PowerShell documentation sources
https://learn.microsoft.com/powershell
Creative Commons Attribution 4.0 International
1.96k stars 1.56k forks source link

Use `OrderedDictionary` to dynamically create new objects #11084

Closed santisq closed 3 months ago

santisq commented 3 months ago

PR Summary

This PR explains how to instantiate new custom objects from OrderedDictionary and its the performance benefits.

PR Checklist

learn-build-service-prod[bot] commented 3 months ago

Learn Build status updates of commit 2639ad4:

:warning: Validation status: warnings

File Status Preview URL Details
reference/docs-conceptual/dev-cross-plat/performance/script-authoring-considerations.md :warning:Warning View (>=powershell-5.1) Details

reference/docs-conceptual/dev-cross-plat/performance/script-authoring-considerations.md

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

github-actions[bot] commented 3 months ago

Expectations

Thanks for your submission! Here's a quick note to provide you with some context for what to expect from the docs team and the process now that you've submitted a PR. Even if you've contributed to this repo before, we strongly suggest reading this information; it might have changed since you last read it.

To see our process for reviewing PRs, please read our editor's checklist and process for managing pull requests in particular. Below is a brief, high-level summary of what to expect, but our contributor guide has expanded details.

The docs team begins to review your PR if you request them to or if your PR meets these conditions:

You can always request a review at any stage in your authoring process, the docs team is here to help! You do not need to submit a fully polished and finished draft; the docs team can help you get content ready for merge.

While reviewing your PR, the docs team may make suggestions, write comments, and ask questions. When all requirements are satisfied, the docs team marks your PR as Approved and merges it. Once your PR is merged, it is included the next time the documentation is published. For this project, the documentation is published daily at 3 p.m. Pacific Standard Time (PST).

santisq commented 3 months ago

I'm sorry about the absolute URIs, I'm not sure how to fix them other than just removing https://learn.microsoft.com/en-us from them to make them relative but unsure if that's the right way to do it 😅

learn-build-service-prod[bot] commented 3 months ago

Learn Build status updates of commit 314c653:

:warning: Validation status: warnings

File Status Preview URL Details
reference/docs-conceptual/dev-cross-plat/performance/script-authoring-considerations.md :warning:Warning View (>=powershell-5.1) Details

reference/docs-conceptual/dev-cross-plat/performance/script-authoring-considerations.md

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

sdwheeler commented 3 months ago

@santisq Thank you for the contributions. When you make contributions like this you need to create a working branch in your fork. Do not work in the main branch. For information about how to create proper links, see https://learn.microsoft.com/contribute/content/how-to-write-links and https://learn.microsoft.com/powershell/scripting/community/contributing/general-markdown#url-type-links.

In general you should remove https://learn.microsoft.com/en-us and remove view query parameters, like ?view=rest-loganalytics-2022-10-27-preview.

Please move your changes to a working branch and fix the links. You can update this PR or close this PR and submit a new PR.

learn-build-service-prod[bot] commented 3 months ago

Learn Build status updates of commit 66a5452:

:warning: Validation status: warnings

File Status Preview URL Details
reference/docs-conceptual/dev-cross-plat/performance/script-authoring-considerations.md :warning:Warning View (>=powershell-5.1) Details

reference/docs-conceptual/dev-cross-plat/performance/script-authoring-considerations.md

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

santisq commented 3 months ago

@santisq Thank you for the contributions. When you make contributions like this you need to create a working branch in your fork. Do not work in the main branch. For information about how to create proper links, see https://learn.microsoft.com/contribute/content/how-to-write-links and https://learn.microsoft.com/powershell/scripting/community/contributing/general-markdown#url-type-links.

In general you should remove https://learn.microsoft.com/en-us and remove view query parameters, like ?view=rest-loganalytics-2022-10-27-preview.

Please move your changes to a working branch and fix the links. You can update this PR or close this PR and submit a new PR.

Thanks @sdwheeler, I've re-opened a new PR #11090.