MicrosoftDocs / WSL

Source code behind the Windows Subsystem for Linux documentation.
https://docs.microsoft.com/windows/wsl
Other
1.9k stars 563 forks source link

Reversed information on git credential manager core/git credential manager for Git 2.36.1 above/below. #1740

Closed pedershk closed 1 year ago

pedershk commented 1 year ago

Documentation Issue

On this page, the instructions for Git >=2.36.1 (greater than or equal to 2.36.1) in fact contain the instructions for Git <=2.36.1 (less than or equal to 2.36.1). In the next section, the instructions are also reversed (naturally).

Git Credential Manager Core (git-credential-manager-core.exe) was replaced by Git Credential Manager (git-credential-manager.exe) in version 2.36.1 of GIT.

Link to documentation page

https://learn.microsoft.com/en-us/windows/wsl/tutorials/wsl-git#git-credential-manager-setup

Suggested Improvements

Reverse the examples provided at https://learn.microsoft.com/en-us/windows/wsl/tutorials/wsl-git#git-credential-manager-setup

craigloewen-msft commented 1 year ago

Related https://github.com/MicrosoftDocs/WSL/issues/1730

mattwojo commented 1 year ago

https://github.com/MicrosoftDocs/WSL/commit/f428a2ff9cfa5d35099a4cd2cf41049a2855c22e

mattwojo commented 1 year ago

Fixed this: https://github.com/MicrosoftDocs/WSL/pull/1779/commits/f428a2ff9cfa5d35099a4cd2cf41049a2855c22e

Thanks for bringing it to our attention!