search

MicrosoftDocs / WindowsCommunityToolkitDocs

Creative Commons Attribution 4.0 International
179 stars 155 forks source link

Broken URL from the Windows Community Toolkit Sample app #515

Open zipswich opened 3 years ago

zipswich commented 3 years ago

The following URL from the Windows Community Toolkit Sample app is invalid: https://github.com/windows-toolkit/Graph-Controls/blob/rel/7.0.0/Microsoft.Toolkit.Graph.Controls/Providers/InteractiveProviderBehavior.cs

image

michael-hawker commented 3 years ago

Thanks @zipswitch, this is a bug in how we try and map links in the Sample App and some oddness to the state of our Graph repo.

You can find more general guidance here and our new docs are here.

zipswich commented 3 years ago

@michael-hawker Thank you for the information. The toolkit seems to have been in flux recently. I am waiting for the major final release of 7.1 or 8.0(?) and organize its NuGet packages in all apps and libraries. I do not want to touch anything now out of fear of breaking anything. It has been working very well.

michael-hawker commented 3 years ago

@zipswich the main refactors were all done for our last 7.0 release, so everything is stable there for the time being. We don't have any major plans outside of staying aligned with WinUI 3/Project Reunion updates for our mirrored packages.

If you're referring to the Graph packages, those have always been in preview and are being re-worked at the moment. We plan to have the new authentication base packages in a stable state soon to align with our current 7.0 code in a few weeks. We then hope to have stable versions of the controls on top of that alongside our 7.1 release.

So, if you're using the Graph components, then hopefully in the next month we'll have a stable package that can work for 7.0 for you alongside an update preview of the Graph controls which works alongside that. If you're just using other toolkit components and not Graph ones that are working alongside that, you can upgrade now.

FYI @shweaver-MSFT.

zipswich commented 3 years ago

@michael-hawker Yes, I was referring to this: https://github.com/windows-toolkit/Graph-Controls/issues/102 I am a bit confused about all these packages, but it does not matter because everything works fine. Once that is officially released with a user guide, I will try to understand the relations and update all of them.

shweaver-MSFT commented 3 years ago

There were actually a variety of bad links in windows-toolkit/Graph-Controls#102, but I went through and updated them. Sorry for any confusion.

@zipswich, I hear you. There have been quite a few breaking changes recently. I definitely appreciate the feedback too. I'll be interested to learn what you think when the final bits are ready :)

zipswich commented 3 years ago

@shweaver-MSFT I will be happy to test any package. As for the Graph, I think I use only two features: One Drive and Translation Service. I have not touched the translation service part for a long time.